feat: introduce starknet verify, verifier set #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puhtaytow
force-pushed
the
marc/starknet_v2_2
branch
from
5d534f9 to
25b4340
Compare
ctoyan
reviewed
Dec 10, 2024
ctoyan
reviewed
Dec 10, 2024
ctoyan
reviewed
Dec 10, 2024
ctoyan
reviewed
Dec 10, 2024
| info!("ready to verify verifier set in poll",); | ||
|
|
||
| let vote = transaction_response.map_or(Vote::NotFound, |tx_receipt| { | ||
| verify_verifier_set(&tx_receipt.1, &verifier_set, &source_gateway_address) |
There was a problem hiding this comment.
Is tx_receipt.1 always the gateway event itself?
There was a problem hiding this comment.
The assumption here is, that ampd receives to "verify" a correct id. If its not then verify_verifier_set would return Vote::NotFound, which is the expected behaviour.
ctoyan
reviewed
Dec 10, 2024
ctoyan
reviewed
Dec 10, 2024
ctoyan
requested changes
Dec 10, 2024
ctoyan
reviewed
Dec 11, 2024
ctoyan
approved these changes
Dec 12, 2024
ctoyan
pushed a commit
that referenced
this pull request
Dec 12, 2024
ctoyan
pushed a commit
that referenced
this pull request
Dec 12, 2024
ctoyan
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce starknet verify verifier set in ampd.
Todos
Steps to Test
Expected Behaviour
Other Notes